Repository navigation
ignore_str to have root cause or known issue description #261
Description
There is array of ignoring error message.
https://github.com/thesofproject/sof-test/blob/master/tools/sof-kernel-log-check.sh#L6
This error message was captured but it is known problem. But there is no description why this is safely ignored.
ignore_str="error: debugfs write failed to idle -16|error: status|iteration [01]"
Ignoring errors is very dangerous and should be carefully reviewed and extensively documented. At the very least this code should be changed to something like:
# because blabla, see bug 1234
ignore_str="$ignore_str"'|error: debugfs write failed to idle -16'
# because blabla, see bug 5678
ignore_str="$ignore_str"'|error: status'
Activity
marc-hb commentedon Jun 25, 2020
I tig blamed the history of that
ignorestrlist:iteration [01]exclusion was added by d238c48 which mentions issue dmesg check still influenced by DSP init fail #43error: statuswas added by commit 50f6ccf . It mentions ASoC: SOF: intel: lower print level to dbg if we will reinit DSP linux#1676debugfs write failed...was added by initial commit b3b7d8d which is unfortunately not specific.@aiChaoSONG could you implement and test this line split? For the
debugfs write...line leave a# TODOfor now.@xiulipan, @plbossart do you know why this this
debugfs write...error must be ignored?aiChaoSONG commentedon Jun 26, 2020
@marc-hb I have no idea why
debugfs write..is added, it is far before I joined CI, but some error string in ignore_str is deprecated. I will try to clean up and split ignore_str after Dragon Boat Holiday.aiChaoSONG commentedon Jun 29, 2020
@Bin-QA Could you please help to find the reason for each ignore_str? though Marc gives some hint, but from the releated commit's message, It's really hard to know the reason, because the message is not clear.
aiChaoSONG commentedon Jun 29, 2020
WIP PR: #268
tools: split ignore_str and give reason for each ignore item
tools: split ignore_str and give reason for each ignore item
tools: split ignore_str and give reason for each ignore item
tools: split ignore_str and give reason for each ignore item