Skip to content

[FEATURE] testbench support for IPC4 #1177

Open

Description

@lgirdwood

Testbench can be built with support for ipc3 or ipc4, but not both. Testbench needs current tests to target IPC3 build only to allow upstreaming of ipc4 testbench (which can then reuse existing tests with changes for ipc4).
@singalsu @ranj063 fyi.
@marc-hb this is needed for v2.10, I think you may also need to help with all the cmake changes to build both flavours of testbench too. Thanks !

Activity

  1. added
    P1Blocker bugs or important features
    on Apr 19, 2024
  2. marc-hb commented on Apr 19, 2024

    @marc-hb
    Collaborator
  3. marc-hb commented on Apr 19, 2024

    @marc-hb
    Collaborator

    Testbench can be built with support for ipc3 or ipc4, but not both.

    Just like any other Kconfig? Or am I missing something?

    To build different Kconfigs then just build twice as usual.

    Testbench needs current tests to target IPC3 build only to allow upstreaming of ipc4 testbench (which can then reuse existing tests with changes for ipc4).

    I spent a fairly large number of minutes trying to understand this and... I failed. AFAIK the IPC type is a build-time decision so I don't understand how tests can "target" one IPC type in particular. I admit I never used the testbench.

    I think you may also need to help with all the cmake changes to build both flavours of testbench too.

    I had a look at thesofproject/sof#9025 but there is very little CMake changes and there is a [DO NOT REVIEW] label for now.

    BTW: this has nothing to do with sof-test but I guess it's more convenient to have all "coverage gaps" in the same place.

  4. singalsu commented on Apr 22, 2024

    @singalsu
    Contributor

    This needs to wait for #9025 to restore IPC3 testbench features (removed in current draft). There should be build for testbench3 and testbench4 and update to sof-test to run both.

  5. marc-hb commented on Apr 22, 2024

    @marc-hb
    Collaborator

    BTW: this has nothing to do with sof-test but I guess it's more convenient to have all "coverage gaps" in the same place.

    update to sof-test to run both.

    I don't think sof-test runs the testbench or that it ever has been? AFAIK there is only some github action compiling it with the Zephyr SDK. Is there anything else?

  6. singalsu commented on Apr 23, 2024

    @singalsu
    Contributor

    There's scripts/host-testbench.sh run, yep it's not from sof-test but some action.

  7. removed their assignment
    on Aug 7, 2024
  8. changed the title [-][FEATURE] Support for different testbench builds with IPC3/4[/-] [+][FEATURE] testbench support for IPC4[/+] on Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Blocker bugs or important featurestype:test coverage gapThis requires a new test case, not just fixing one

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions