You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Testbench can be built with support for ipc3 or ipc4, but not both. Testbench needs current tests to target IPC3 build only to allow upstreaming of ipc4 testbench (which can then reuse existing tests with changes for ipc4). @singalsu@ranj063 fyi. @marc-hb this is needed for v2.10, I think you may also need to help with all the cmake changes to build both flavours of testbench too. Thanks !
Testbench can be built with support for ipc3 or ipc4, but not both.
Just like any other Kconfig? Or am I missing something?
To build different Kconfigs then just build twice as usual.
Testbench needs current tests to target IPC3 build only to allow upstreaming of ipc4 testbench (which can then reuse existing tests with changes for ipc4).
I spent a fairly large number of minutes trying to understand this and... I failed. AFAIK the IPC type is a build-time decision so I don't understand how tests can "target" one IPC type in particular. I admit I never used the testbench.
I think you may also need to help with all the cmake changes to build both flavours of testbench too.
I had a look at thesofproject/sof#9025 but there is very little CMake changes and there is a [DO NOT REVIEW] label for now.
BTW: this has nothing to do with sof-test but I guess it's more convenient to have all "coverage gaps" in the same place.
This needs to wait for #9025 to restore IPC3 testbench features (removed in current draft). There should be build for testbench3 and testbench4 and update to sof-test to run both.
BTW: this has nothing to do with sof-test but I guess it's more convenient to have all "coverage gaps" in the same place.
update to sof-test to run both.
I don't think sof-test runs the testbench or that it ever has been? AFAIK there is only some github action compiling it with the Zephyr SDK. Is there anything else?
Activity
marc-hb commentedon Apr 19, 2024
I searched email and found this:
marc-hb commentedon Apr 19, 2024
Just like any other Kconfig? Or am I missing something?
To build different Kconfigs then just build twice as usual.
I spent a fairly large number of minutes trying to understand this and... I failed. AFAIK the IPC type is a build-time decision so I don't understand how tests can "target" one IPC type in particular. I admit I never used the testbench.
I had a look at thesofproject/sof#9025 but there is very little CMake changes and there is a [DO NOT REVIEW] label for now.
BTW: this has nothing to do with sof-test but I guess it's more convenient to have all "coverage gaps" in the same place.
singalsu commentedon Apr 22, 2024
This needs to wait for #9025 to restore IPC3 testbench features (removed in current draft). There should be build for testbench3 and testbench4 and update to sof-test to run both.
marc-hb commentedon Apr 22, 2024
I don't think sof-test runs the testbench or that it ever has been? AFAIK there is only some github action compiling it with the Zephyr SDK. Is there anything else?
singalsu commentedon Apr 23, 2024
There's scripts/host-testbench.sh run, yep it's not from sof-test but some action.
[-][FEATURE] Support for different testbench builds with IPC3/4[/-][+][FEATURE] testbench support for IPC4[/+]