Repository navigation
build-with-zephyr: fix submodules, get ready for new python script - #412
Merged
Merged
Conversation
west init knows how to create a directory, no need to ask the user. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
June 8, 2022 23:47
marc-hb
requested review from
anton-intel,
deb-intel,
greg-intel,
intelkevinputnam and
lgirdwood
as code owners
June 8, 2022 23:47
Collaborator
Author
|
The many EDIT: |
Add missing `git submodule update` as reported by @plbossart (thx!) Also make the documentation ready for `xtensa-build-zephyr.py` which... does not have any hack to automatically download git submodules like the older .sh script has. As a side-effect, this breaks down the process and adds an intermediate `west build` step which removes one layer of indirection in case of some Zephyr environment issue. Cannot fully switch to the Python version yet because of bugs like thesofproject/sof#5906 but do recommend users to start trying it. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
As usual to see a rendered version of the modified file go to "Files changed" -> "..." -> "View File" |
plbossart
approved these changes
Jun 9, 2022
lgirdwood
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing
git submodule updateas reported by @plbossart (thx!)Also make the documentation ready for
xtensa-build-zephyr.pywhich... does not have any hack to automatically download git submodules
like the older .sh script has.
As a side-effect, this breaks down the process and adds an intermediate
west buildstep which removes one layer of indirection in case of someZephyr environment issue.
Cannot fully switch to the Python version yet because of bugs like
thesofproject/sof#5906 but do recommend users to
start trying it.