Skip to content

Minor grammar and style changes - #383

Merged
anton-intel merged 1 commit into
thesofproject:masterfrom
anton-intel:chromebook-options-edits
Nov 16, 2021
Merged

anton-intel merged 1 commit into
thesofproject:masterfrom
anton-intel:chromebook-options-edits

Conversation

@anton-intel

Copy link
Copy Markdown
Contributor

Just little nitpicks.

@lgirdwood

Copy link
Copy Markdown
Member

@anton-intel btw, feel free to merge grammar and style fixes. I cant add any value in review.

@anton-intel
anton-intel merged commit 79572cd into thesofproject:master Nov 16, 2021
@marc-hb

marc-hb commented Nov 19, 2021

Copy link
Copy Markdown
Collaborator

@anton-intel please add the original author as a reviewer on fixes like this. For at least two reasons:

  • Non-native speakers can learn from you
  • They can also make sure any English mistake they made is not technically misinterpreted and amplified by you

GitHub has a useful "blame" button where you can see who wrote each line.

@marc-hb marc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great except for the Portage bit. It's not very important so nothing urgent.

anything in Chrome OS and even build an entire system image. The
``cros_sdk`` requires significant disk space and some learning
effort if you are not already familiar with Portage, a package
management system in Gentoo, and Linux kernel build process.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what I tried to say. I meant: being familiar with Portage and especially with building the kernel in Portage.

Portage is also a package management for Gentoo but in Chrome OS the package management part is not really used, it's really the build system that is.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb, I created PR #387 for this correction.

@greg-intel

Copy link
Copy Markdown
Contributor

I would actually LIKE to be on all README and documentation tweaks.
For one thing, I'm still learning the code base, so things don't have intuitive clarity for me.
Also, I'm also into documentation being as clear as possible.
Hopefully I don't regret saying this.

@marc-hb

marc-hb commented Nov 19, 2021 •

Copy link
Copy Markdown
Collaborator

I would actually LIKE to be on all README and documentation tweaks.

Thanks! we can always use more reviewers (and native speakers).
@greg-intel please submit a PR where you add yourself to the CODEOWNERS file and let's discuss it there, it's off-topic here.

EDIT: already submitted in #386

Hopefully I don't regret saying this.

There's always some "unsubscribe" button not far...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants