Repository navigation
Logger filtering extra info - #299
Merged
deb-intel merged 4 commits intoOct 27, 2020
Merged
Conversation
Logger can't show trace removed during compilation time, add note with this information. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
ktrzcinx
requested review from
deb-intel,
intelkevinputnam and
lgirdwood
as code owners
October 20, 2020 11:34
lgirdwood
requested changes
Oct 20, 2020
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
We need to include the Linux command line for disabling the SOF driver runtime PM. i.e. this guide should be a one stop shop for tracing
ktrzcinx
force-pushed
the
logger-filtering-extra-info
branch
3 times, most recently
from
October 22, 2020 08:09
f0dba0f to
7101a58
Compare
lgirdwood
approved these changes
Oct 22, 2020
This may be not obvious for filter user, that keeping settings in firmware runtime memory is related with settings reset after firmware reboot on power gating. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Filtering mechanism works mainly on firmware side, so only upcoming traces will be affected new filtering settings. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Noticeable consequence of keeping active filter state in firmware, is keeping old setup during logger reset. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
ktrzcinx
force-pushed
the
logger-filtering-extra-info
branch
from
October 23, 2020 11:57
7101a58 to
d68fe27
Compare
deb-intel
approved these changes
Oct 27, 2020
deb-intel
left a comment
deb-intel
left a comment
Collaborator
There was a problem hiding this comment.
Will make minor grammatical edits in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add few extra information about trace filtering system limitations.