Repository navigation
Remove duplicate v2.2.x/sof-v2.2/intel-signed/sof-*.ldc dict files - #92
Merged
Merged
Conversation
Fixes commit 512d219 ("add v2.2 firmware, topology and tools binaries"). The HOWTO-new-release.md provides slow and careful, step by step instructions including the following text; however it looks like the v2.2 commit was a bit rushed. If the `intel-signed/*.ri` files came with some corresponding `*.ldc` dictionary files, do not add the corresponding `*.ldc` files to the release because they should be exact duplicates of the community `*.ldc` files. The following checksums proves that these files are duplicates: ``` $ sof-bin/v2.2.x/sof-v2.2$ shasum *.ldc */*.ldc | sort 05d8a94e7aa31dfed1e5696733f263193f1b44a3 intel-signed/sof-jsl.ldc 05d8a94e7aa31dfed1e5696733f263193f1b44a3 sof-jsl.ldc 344dd3aecfc530556af997ebb440662edb97791b intel-signed/sof-apl.ldc 344dd3aecfc530556af997ebb440662edb97791b sof-apl.ldc 344dd3aecfc530556af997ebb440662edb97791b sof-glk.ldc 6b1fcf9f5cd77fa2051726d9cb3fdd7a668f0cee sof-bdw.ldc 935d3e85c9ed9e852cd9d06426e9aa5ec72d2b7f intel-signed/sof-icl.ldc 935d3e85c9ed9e852cd9d06426e9aa5ec72d2b7f sof-icl.ldc af73bd7ec4860583383deb6c8196c2a2018e7bf2 intel-signed/sof-cnl.ldc af73bd7ec4860583383deb6c8196c2a2018e7bf2 sof-cfl.ldc af73bd7ec4860583383deb6c8196c2a2018e7bf2 sof-cml.ldc af73bd7ec4860583383deb6c8196c2a2018e7bf2 sof-cnl.ldc bab02299351aea1919259becc8874afdf5955517 intel-signed/sof-adl.ldc bab02299351aea1919259becc8874afdf5955517 intel-signed/sof-adl-s.ldc bab02299351aea1919259becc8874afdf5955517 intel-signed/sof-ehl.ldc bab02299351aea1919259becc8874afdf5955517 intel-signed/sof-tgl-h.ldc bab02299351aea1919259becc8874afdf5955517 intel-signed/sof-tgl.ldc bab02299351aea1919259becc8874afdf5955517 sof-adl.ldc bab02299351aea1919259becc8874afdf5955517 sof-adl-s.ldc bab02299351aea1919259becc8874afdf5955517 sof-ehl.ldc bab02299351aea1919259becc8874afdf5955517 sof-tgl-h.ldc bab02299351aea1919259becc8874afdf5955517 sof-tgl.ldc e0207abdfc4751729c4ed27da5849c4016bbba14 sof-byt.ldc e0207abdfc4751729c4ed27da5849c4016bbba14 sof-cht.ldc ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
September 8, 2022 16:59
Contributor
|
@marc-hb Thank you! LGTM. Can you please add Keqiao and me to reviewers? @keqiaozhang FYI. Can you please give a look? I think this is helpful for v2.2.2 |
keqiaozhang
approved these changes
Sep 9, 2022
keqiaozhang
left a comment
keqiaozhang
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I will keep it in mind in the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes commit 512d219 ("add v2.2 firmware, topology and tools binaries"). The HOWTO-new-release.md provides slow and careful, step by step instructions including the following text; however it looks like the v2.2 commit was a bit rushed.
If the
intel-signed/*.rifiles came with some corresponding*.ldcdictionary files, do not add the corresponding
*.ldcfiles to therelease because they should be exact duplicates of the community
*.ldcfiles.The following checksums proves that these files are duplicates:
Signed-off-by: Marc Herbert marc.herbert@intel.com