Repository navigation
Deprecate go.sh - #40
Merged
Merged
Conversation
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
May 6, 2021 18:21
marc-hb
requested review from
XiaoyunWu6666,
aiChaoSONG,
fredoh9,
keqiaozhang,
kv2019i,
lgirdwood,
lyakh,
perexg,
plbossart,
ranj063 and
ujfalusi
May 6, 2021 20:04
kv2019i
reviewed
May 7, 2021
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. One minor typo in comments, but nothing pops up.
Fixes thesofproject#38 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
kv2019i
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review commits separately otherwise github fails to detect the 100% match rename and displays something confusing.