Skip to content

ASoC: SOF: Intel: IPC: add IPC counters #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jajanusz wants to merge 1 commit into from
Closed

ASoC: SOF: Intel: IPC: add IPC counters #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sound/soc/sof/intel/hda.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ void hda_ipc_dump(struct snd_sof_dev *sdev)
u32 hipcie;
u32 hipct;
u32 hipcctl;
u32 ipc_rec, ipc_proc;

/* read IPC status */
hipcie = snd_sof_dsp_read(sdev, HDA_DSP_BAR, HDA_DSP_REG_HIPCIE);
Expand All @@ -195,6 +196,14 @@ void hda_ipc_dump(struct snd_sof_dev *sdev)
dev_err(sdev->dev,
"error: host status 0x%8.8x dsp status 0x%8.8x mask 0x%8.8x\n",
hipcie, hipct, hipcctl);

@xiulipan xiulipan May 18, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jajanusz
Please add some inline comments to explain what is doing here.

ipc_rec = snd_sof_dsp_read(sdev, HDA_DSP_BAR,
HDA_DSP_SRAM_REG_FW_IPC_RECEIVED_COUNT);
ipc_proc = snd_sof_dsp_read(sdev, HDA_DSP_BAR,
HDA_DSP_SRAM_REG_FW_IPC_PROCESSED_COUNT);

dev_err(sdev->dev, "error: ipc received: %u processed: %u\n",

@xiulipan xiulipan May 18, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dev_err(sdev->dev, "error: ipc received: %u processed: %u\n",
dev_err(sdev->dev, "error: DSP ipc received: %u processed: %u\n",

ipc_rec, ipc_proc);
}

static int hda_init(struct snd_sof_dev *sdev)
Expand Down
4 changes: 3 additions & 1 deletion sound/soc/sof/intel/hda.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@
/* FW and ROM share offset 4 */
#define HDA_DSP_SRAM_REG_FW_STATUS (HDA_DSP_MBOX_OFFSET + 0x4)
#define HDA_DSP_SRAM_REG_FW_TRACEP (HDA_DSP_MBOX_OFFSET + 0x8)
#define HDA_DSP_SRAM_REG_FW_END (HDA_DSP_MBOX_OFFSET + 0xc)
#define HDA_DSP_SRAM_REG_FW_IPC_RECEIVED_COUNT (HDA_DSP_MBOX_OFFSET + 0xc)
#define HDA_DSP_SRAM_REG_FW_IPC_PROCESSED_COUNT (HDA_DSP_MBOX_OFFSET + 0x10)
#define HDA_DSP_SRAM_REG_FW_END (HDA_DSP_MBOX_OFFSET + 0x14)
Comment thread
plbossart marked this conversation as resolved.

#define HDA_DSP_MBOX_UPLINK_OFFSET 0x81000

Expand Down