Repository navigation
ASoC: SOF: update sof_ipc_pipe_new - #752
Merged
plbossart merged 1 commit intoMar 27, 2019
Merged
Conversation
tlauda
force-pushed
the
topic/update-pipe-new-ipc
branch
from
March 27, 2019 09:25
e582ab5 to
3e268bc
Compare
tlauda
force-pushed
the
topic/update-pipe-new-ipc
branch
from
March 27, 2019 12:01
3e268bc to
a10e46b
Compare
plbossart
reviewed
Mar 27, 2019
Updates sof_ipc_pipe_new struct to align with changes on FW side. Only field names are changing. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
force-pushed
the
topic/update-pipe-new-ipc
branch
from
March 27, 2019 14:46
a10e46b to
12b3937
Compare
ranj063
approved these changes
Mar 27, 2019
dbaluta
reviewed
Mar 27, 2019
| @@ -218,21 +218,25 @@ struct sof_ipc_comp_reply { | |||
| * Pipeline | |||
| */ | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Hi @tlauda,
Sorry for being late. One minor comment here. Please use a more specific subject line. "Update" is just too generic.
For example, you can say ASoC: SOF: Align sof_ipc_pipe_new with FW code
Author
There was a problem hiding this comment.
@dbaluta Thanks for the suggestion. I'll try to do better next time.
plbossart
approved these changes
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates sof_ipc_pipe_new struct to align with changes
on FW side. Only field names are changing.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com