Repository navigation
Fix/nocodec hdaudio compatibility - #685
Merged
plbossart merged 2 commits intoMar 4, 2019
Merged
Conversation
If the HDAudio link is configured but not used, there are multiple issues with syspend/resume. Just make the two options incompatible and move on. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
since we've made the two options mutually incompatible in Kconfig, there is no point in maintaining the code that falls back to nocodec if there is no external HDAudio codec detected. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
xun2z
approved these changes
Mar 4, 2019
xun2z
left a comment
xun2z
left a comment
There was a problem hiding this comment.
Check on up2 and no functional issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix #512
This is compiled-tested only so would need a check on up2 that there is no functional issue.