Repository navigation
more cleanups - #632
Merged
plbossart merged 5 commits intoFeb 8, 2019
Merged
more cleanups#632
Conversation
Remove unused prototypes, cleanup comments and remove id field (not sure what it was used for, if ever) Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
use to_pci_dev() as needed, no need to have a dedicated field in the core Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
copy/pastes likely, fix missing const Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
again missing const, add Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
we set the .ignore_machine field dynamically to the machine driver name, so add note to say we cannot use const (reported by checkpatch) Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
ranj063
approved these changes
Feb 7, 2019
oder-chiou
pushed a commit
to oder-chiou/linux-soundwire
that referenced
this pull request
May 5, 2026
Fix checkpatch code style warnings: WARNING: quoted string split across lines thesofproject#480: FILE: net/core/pktgen.c:480: + "Packet Generator for packet performance testing. " + "Version: " VERSION "\n"; WARNING: quoted string split across lines thesofproject#632: FILE: net/core/pktgen.c:632: + " udp_src_min: %d udp_src_max: %d" + " udp_dst_min: %d udp_dst_max: %d\n", Signed-off-by: Peter Seiderer <ps.report@gmx.net> Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove unused fields, remove pci field (use to_pci_dev() instead, add const when we missed them.