Repository navigation
ASoC: SOF: add field to keep track of active cores for SMP - #557
Conversation
|
fixes #394 |
e1c3666 to
3cba656
Compare
3cba656 to
f79dfca
Compare
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
What if a platform can have two cores at boot? Better use e.g. init_core_mask in the description and make no assumption that there is a single core.
@plbossart got it |
f79dfca to
0b87b03
Compare
|
@plbossart updated now. |
0b87b03 to
5059cc7
Compare
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
Looks good now, but the partitioning between patch1 and patch2 is odd.
Also we add this new field but do nothing with it?
There was a problem hiding this comment.
this is changed in the next patch, so could we squash this into the next patch and only add the definitions for active core mask in this patch, and make use of it in the next?
5059cc7 to
2dca447
Compare
|
This seems to be ok but does this solve the issue reported by @tlauda? |
|
@plbossart this does fix @tlauda 's issue. But the definition of an active core is not that there's an active stream. It just says that there's a pipeline scheduled to run on it so keep it on. I'm not sure how the fw handles the multicore scenario. So to only turn the core on when the pipeline is active would probably be a future optimization. |
|
On 2/13/19 3:03 PM, Ranjani Sridharan wrote:
@plbossart <https://github.com/plbossart> this does fix @tlauda
<https://github.com/tlauda> 's issue.
But the definition of an active core is not that there's an active
stream. It just says that there's a pipeline scheduled to run on it so
keep it on. I'm not sure how the fw handles the multicore scenario. So
to only turn the core on when the pipeline is active would probably be
a future optimization.
Well that's highly misleading and turning off the cores that are not
used is actually required for D0ix. We cannot leave all the cores
present in the topology on by default.
Call this flag enabled_core then or something along those lines. active
really means "in use" in kernel circles.
|
|
@plbossart sure. let me change it |
2dca447 to
61464c3
Compare
|
@plbossart done |
|
can you also update the comments: /* update active cores mask */ |
Add a field "enabled_cores_mask" to keep track of the cores that are enabled in SMP and update it during topology loading/unloading. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Add a init_core_mask member to sof_intel_dsp_desc and set the value for SKL+ platforms. This will be used to specify which cores are enabled after fw boot is complete. Also make snd_sof_dsp_run() op return the init_core_mask. SKL- platforms with single core DSP's just return 1. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
61464c3 to
e0272e7
Compare
@plbossart sorry about that. fixed now |
2 participants
Add a field "active_cores_mask" to keep track of the active
cores for multicore platforms and update it during topology
loading/unloading.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com