Repository navigation
ASoC: SOF: Add topology parsing and load of IPC4 ASRC component - #5335
Merged
Merged
Conversation
Collaborator
Author
|
WIP - it still fails with sof-hda-benchmark-asrc32.tplg load. This should address issue thesofproject/sof#9845 . |
ranj063
reviewed
Feb 20, 2025
ranj063
previously approved these changes
Feb 20, 2025
ujfalusi
reviewed
Feb 21, 2025
singalsu
force-pushed
the
asrc_load_add
branch
from
February 21, 2025 08:27
a0eb705 to
c6e04f8
Compare
ujfalusi
reviewed
Feb 21, 2025
Collaborator
Author
|
This version works with my test topology. @ujfalusi Thanks for the fix suggestion! I'll continue with addressing the review comments. |
singalsu
force-pushed
the
asrc_load_add
branch
from
February 21, 2025 10:49
c6e04f8 to
69791a8
Compare
singalsu
marked this pull request as ready for review
February 21, 2025 10:51
singalsu
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood and
plbossart
as code owners
February 21, 2025 10:51
ujfalusi
reviewed
Feb 21, 2025
singalsu
force-pushed
the
asrc_load_add
branch
from
February 21, 2025 12:58
69791a8 to
3e1a8ca
Compare
lgirdwood
approved these changes
Feb 21, 2025
ujfalusi
approved these changes
Feb 21, 2025
ujfalusi
reviewed
Feb 21, 2025
ujfalusi
self-requested a review
February 21, 2025 13:57
This patch adds to IPC4 topology parsing the support for the asynchronous sample rate converter (ASRC) SOF component. It is applied for the DAPM widget type SND_SOC_TPLG_DAPM_ASRC. The parsed SOF tokens for ASRC are SOF_TKN_ASRC_RATE_OUT and SOF_TKN_ASRC_OPERATION_MODE. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
asrc_load_add
branch
from
February 21, 2025 15:04
3e1a8ca to
6cc2a6a
Compare
Collaborator
|
Tested on MTL with an ASRC HDA topology - passed. |
ranj063
approved these changes
Feb 21, 2025
bardliao
approved these changes
Feb 24, 2025
Member
|
Test failures are unrelated to this PR and are know problems with some DUTs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds to IPC4 topology parsing the support for the asynchronous sample rate converter (ASRC) SOF component. It is applied for the DAPM widget type SND_SOC_TPLG_DAPM_ASRC.
The parsed SOF tokens for ASRC are SOF_TKN_ASRC_RATE_OUT and SOF_TKN_ASRC_OPERATION_MODE.