Repository navigation
Lenovo 83hm - #5248
Merged
Merged
Lenovo 83hm#5248
Conversation
simontrimmer
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
November 20, 2024 15:28
charleskeepax
approved these changes
Nov 20, 2024
Collaborator
Author
|
@bardliao Here we go - hopefully this is the final piece of the puzzle (in combination with the topology change we have been smithing in thesofproject/sof#9666 ) |
lgirdwood
approved these changes
Nov 20, 2024
Member
Nitpick: the commit messages could have a bit more context. Might need this for upstream to ALSA. |
Collaborator
|
The second commit is easy to understand. However, we still need a commit message. Maybe just "Add debug message when SOC_SDW_CODEC_MIC is enabled" |
In addition to changing the DMI match to examine the product name rather than the SKU, this adds the quirk to inform the machine driver to not bind in the cs42l43 microphone DAI link. Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
… quirk Add debug message when SOC_SDW_CODEC_MIC is enabled (which informs the machine driver to not bind in the cs42l43 microphone DAI link). Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
simontrimmer
force-pushed
the
lenovo-83hm
branch
from
November 21, 2024 11:21
e7ca078 to
e03ec26
Compare
Collaborator
Author
|
Good thinking - I've rebased and updated the latter one to have a description, as it would be easy to miss that it turns something off |
bardliao
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.