Skip to content

ALSA: pcm: add comment warning that SNDRV_PCM_RATE_* bits are ABI - #4985

Closed
marc-hb wants to merge 1 commit into
thesofproject:topic/sof-devfrom
marc-hb:pcm-bits-comment
Closed

marc-hb wants to merge 1 commit into
thesofproject:topic/sof-devfrom
marc-hb:pcm-bits-comment

Conversation

@marc-hb

@marc-hb marc-hb commented May 8, 2024

Copy link
Copy Markdown
Collaborator

Add a comment warning that SNDRV_PCM_RATE_* were copied in 2017 to alsa-lib file "tplg_local.h" which makes them an ABI now.

Pure comment fix, no code change.

Link: #4966

Add a comment warning that SNDRV_PCM_RATE_* were copied in 2017 to
alsa-lib file "tplg_local.h" which makes them an ABI now.

Pure comment fix, no code change.

Link: thesofproject#4966

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb

marc-hb commented May 8, 2024

Copy link
Copy Markdown
Collaborator Author

For convenience: alsa-project/alsa-lib@c550a421a3

@marc-hb
marc-hb marked this pull request as ready for review May 8, 2024 23:48
@marc-hb
marc-hb requested a review from yongzhi1 May 8, 2024 23:48
@dbaluta

dbaluta commented May 9, 2024

Copy link
Copy Markdown
Collaborator

Looks good to me! This should be merged directly via Mark Brown's tree and then cherry-picked (or rebased) back here.

@plbossart

Copy link
Copy Markdown
Member

let's ask @tiwai for his advice/comments

@tiwai

tiwai commented May 9, 2024

Copy link
Copy Markdown

Maybe it'd be clearer to move it to uapi/sound/asound.h, as an official part of uapi?

@marc-hb

marc-hb commented May 14, 2024

Copy link
Copy Markdown
Collaborator Author

Maybe it'd be clearer to move it to uapi/sound/asound.h, as an official part of uapi?

Anyone else agrees or disagrees? This was supposed to be a "quick doc fix" but it's been 5 days now so if it's significantly more complicated than expected then I will just close it.

@dbaluta

dbaluta commented May 14, 2024

Copy link
Copy Markdown
Collaborator

Maybe it'd be clearer to move it to uapi/sound/asound.h, as an official part of uapi?

Anyone else agrees or disagrees? This was supposed to be a "quick doc fix" but it's been 5 days now so if it's significantly more complicated than expected then I will just close it.

Do you mean to move all SNDRV_PCM_RATE_* to uapi/sound/asound.h? This should be fine then remove it from "tplg_local.h"

@marc-hb

marc-hb commented May 23, 2024

Copy link
Copy Markdown
Collaborator Author

Let's be realistic: I'm not going to have the time to do any of this any time soon.

@marc-hb marc-hb closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants