Repository navigation
Conversation
A peripheral may experience an unexpected unattach and attach cycle before a stream is prepared. It will fail to program registers if we try to program them before the peripheral is attached. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
plbossart
reviewed
Sep 6, 2023
| return -ETIMEDOUT; | ||
| } | ||
| mutex_lock(&bus->bus_lock); | ||
|
|
Member
There was a problem hiding this comment.
the problem is that the detach could perfectly happen while you already started programming the first port register. There's nothing that tells us when the codec will lose sync. So I will assert that the electrical parts need to be fixed, there's no reason why the de-attach should happen other than a bad link
Collaborator
Author
|
Let's focus on the reason of UNATTACHED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peripheral may experience an unexpected unattach and attach cycle before a stream is prepared. It will fail to program registers if we try to program them before the peripheral is attached.