Repository navigation
ASoC: SOF: sof-audio: test virtual widget in sof_walk_widgets_in_order - #4389
Merged
Merged
Conversation
bardliao
requested review from
ajitkupandey,
dbaluta,
kuanhsuncheng,
kv2019i,
lgirdwood,
ujfalusi and
yaochunhung
as code owners
May 30, 2023 11:33
Testing virtual widget is required in many functions. No function changed in this commit. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
plbossart
reviewed
May 30, 2023
Virtual widgets are added for the purpose of showing connections between aggregated DAIs in SDW topologies. However, we shouldn't touch them in SOF. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
plbossart
approved these changes
Jun 1, 2023
ranj063
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual widgets may be added in topologies for some purpose. However,
we shouldn't touch them in SOF.