Skip to content

ASoC: SOF: ipc4: Fetch CPC from tplg mod_cfg or from manifest - #4262

Closed
ujfalusi wants to merge 9 commits into
thesofproject:topic/sof-devfrom
ujfalusi:peter/sof/pr/ipc4_cpc_from_manifest_01
Closed

ujfalusi wants to merge 9 commits into
thesofproject:topic/sof-devfrom
ujfalusi:peter/sof/pr/ipc4_cpc_from_manifest_01

Conversation

@ujfalusi

@ujfalusi ujfalusi commented Mar 24, 2023 •

Copy link
Copy Markdown
Collaborator

Hi,

the MOD_INIT_INSTANCE message always contains a base_cfg struct and in there the CPC value must be set to non 0 to indicate the processing need of the instantiated module with ti's configuration.
Currently we have one module specific token to pass a single, static CPC value in topology. Some module has this set, some does not, but in any case it is not reflecting the real processing need based on the configuration, parameters.

The firmware's manifest however contains mod_cfg array which contains CPC value for the module's different configuration, the CPC number should be looked up by matching the obs/ibs in manifest mod_cfg and in the runtime base_cfg obs/ibs and pick the exact matched CPC or maximum CPC.

Since the manifest is part of the firmware binary, it is hard to modify and might contain out of date or non correct value, hence we should have a way to provide similar mod_cfg type of info via tplg and use that if it is present.

This series implements this CPC lookup and configuration for the modules.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants