Repository navigation
ASoC: SOF: ipc4-mtrace: process pending logs upon FW crash - #4186
Merged
plbossart merged 1 commit intoFeb 10, 2023
Merged
Conversation
kv2019i
requested review from
ajitkupandey,
bardliao,
dbaluta,
kuanhsuncheng,
lgirdwood,
plbossart,
ranj063 and
yaochunhung
as code owners
February 9, 2023 18:01
Collaborator
Author
|
Verified that with this PR, we can capture the DSP crash logs via mtrace and make DSP crashes visible in CI results that are published here on github. I used thesofproject/sof#7071 as a test PR to trigger a crash. |
ujfalusi
reviewed
Feb 10, 2023
If the DSP firmware has crashed, some log messages may be pending in the mtrace buffer, but not consumed by the driver as no IPC notification has been sent by the firmware. Check the buffer status for all mtrace slots and ensure any pending log messages are processed before DSP is possibly powered down and the log buffer contents is lost. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202302-mtrace-panic-flush
branch
from
February 10, 2023 12:35
d581aba to
4f18d87
Compare
plbossart
approved these changes
Feb 10, 2023
ranj063
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the DSP firmware has crashed, some log messages may be pending in the shared memory, but DSP was not able to send a IPC notification anymore. Check the buffer status for all mtrace slots and ensure any pending log messages are processed before powering down the DSP.
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com