Repository navigation
add tracing POC - #3482
Merged
Merged
add tracing POC#3482
Conversation
ranj063
reviewed
Mar 6, 2022
plbossart
reviewed
Mar 7, 2022
plbossart
reviewed
Mar 22, 2022
Member
|
@nklayman you have a set of conflicts, need to rebase this branch |
nklayman
force-pushed
the
add-tracing
branch
3 times, most recently
from
March 29, 2022 20:26
06ef86a to
72450a7
Compare
ranj063
reviewed
Mar 29, 2022
Collaborator
|
@ujfalusi do you mind taking a look at this one too? |
nklayman
force-pushed
the
add-tracing
branch
4 times, most recently
from
March 29, 2022 22:29
157d89e to
7fbb3fa
Compare
nklayman
marked this pull request as ready for review
March 30, 2022 00:03
nklayman
requested review from
RanderWang,
ajitkupandey,
bardliao,
dbaluta,
juimonen,
keyonjie,
kuanhsuncheng,
kv2019i,
lgirdwood,
libinyang,
lyakh,
singalsu and
ujfalusi
as code owners
March 30, 2022 00:03
Enables tracking of use_count during widget setup and free routines. Useful for debugging unbalanced use_counts during suspend/resume. Signed-off-by: Noah Klayman <noah.klayman@intel.com>
nklayman
force-pushed
the
add-tracing
branch
2 times, most recently
from
April 8, 2022 05:20
3062e2c to
0b56cc8
Compare
ujfalusi
previously approved these changes
Apr 8, 2022
ranj063
reviewed
Apr 8, 2022
plbossart
reviewed
Apr 8, 2022
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
This looks very good @nklayman, see below a couple of nit-picks to make the upstream reviews easier. Both @ranj063 and @ujfalusi had the same type of comments so chances are others will ask why we removed logs without replacing them with a tracepoint, and "pierre asked for it" should become a formal removal patch applied earlier than the tracepoint conversion.
One more round and we should be good to go. Happy Friday!
plbossart
previously approved these changes
Apr 13, 2022
ranj063
reviewed
Apr 13, 2022
The Intel HDaudio controller relies on a single interrupt line which wire-ORs multiple interrupt sources, such as stream, IPC, SoundWire and wakes. This patch adds the ability to trace each event occurrence. Signed-off-by: Noah Klayman <noah.klayman@intel.com>
This patch removes an unneeded dev_vdbg call in hda-stream. Signed-off-by: Noah Klayman <noah.klayman@intel.com>
This patch removes some unneeded dev_vdbg calls. Signed-off-by: Noah Klayman <noah.klayman@intel.com>
This patch replaces all dev_vdbg calls with tracepoints to reduce overhead and enable use of trace collection and analysis tools. Signed-off-by: Noah Klayman <noah.klayman@intel.com>
This patch removes unneeded dev_vdbg calls and replaces remaining ones with tracepoints to reduce overhead and enable use of trace collection and analysis tools. Signed-off-by: Noah Klayman <noah.klayman@intel.com>
This patch replaces dev_vdbg with tracepoints in new ipc4-loader code. Signed-off-by: Noah Klayman <noah.klayman@intel.com>
plbossart
approved these changes
Apr 19, 2022
Member
Collaborator
|
I'm not familiar with this part of the code sorry. I spent a fair amount of time reviewing the user space part of this in thesofproject/sof-test#877 so I believe I've done my fair share :-) |
Member
|
Congratulations @nklayman, all your tracing patches will be in the Linux kernel 6.1. https://lore.kernel.org/alsa-devel/166362902112.3419825.5579029076965625073.b4-ty@kernel.org/T/#t Yay! |
Author
|
Awesome! Thanks everyone for the help with this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tracepoints for widget setup/free and hda irq events. See this article for information on how kernel tracepoints are defined.