Repository navigation
Conversation
dac44c0 to
04be56f
Compare
| EXPORT_SYMBOL_GPL(snd_soc_poweroff); | ||
|
|
||
| const struct dev_pm_ops snd_soc_pm_ops = { | ||
| .prepare = snd_soc_prepare, |
There was a problem hiding this comment.
The .prepare is used when the device is suspending, preceding the .suspend callback if I recall right.
Are you suspecting that a work from a previous resume is still executing or waiting for execution?
If that is the case then should we try to cancel it if it is not already running (we are after all going to suspend) or wait until it finishes to execute the work (cancel_work_sync())?
There was a problem hiding this comment.
yes, the traces show that we try to bring the device in D0, but suspend immediately.
This patch was intended to delay the suspend until the resume is actually completed. i don't think it makes sense to cancel the resume, that is asking for trouble. We want to wait for the resume to be scheduled/completed, and if there's nothing to do to continue the suspend.
However the traces show that the freeze error happens before we reach the .prepare, so that's not helping.
04be56f to
5001794
Compare
|
Grrrr, PR devices not available. what a waste of time. |
|
SOFCI TEST |
|
SOF CI is behaving today, the devices timed out in https://sof-ci.01.org/linuxpr/PR3374/build6998/devicetest/ |
|
SOFCI TEST |
9003609 to
9859a43
Compare
Provided by Takashi Iwai: https://github.com/thesofproject/linux/files/7902858/snd-power-lock-ignore-freezer-v2.diff.txt Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Suggested by Takashi Iwai Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Add traces to see what happens when one task refuses to freeze. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Somehow the code gets stuck somewhere while starting the flush on suspend. Traces seem to suggest the issue is either in dapm_mark_endpoints_dirty(card); or snd_soc_dapm_sync(&card->dapm); Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
9859a43 to
1492724
Compare
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
SOFCI TEST |
2 participants
Add traces to see what happens when one task refuses to freeze.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com