Repository navigation
ASoC: da7219-aad: fix possible race condition in interrupt - #2749
Merged
plbossart merged 1 commit intoMay 4, 2021
Merged
Conversation
When the irq_thread deals with jack removal, it modifies DAPM pin states and then wait for workqueues to complete. The problem is that those workqueues also modify DAPM pin states, and the DAPM pin states may be inconsistent. This patch suggests first waiting for scheduled workqueues to complete before changing the DAPM pin states. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood and
ranj063
as code owners
February 9, 2021 17:52
Collaborator
|
looks like a legitimate fix to me! |
ranj063
approved these changes
Feb 9, 2021
paulstelian97
approved these changes
Feb 10, 2021
Member
Author
|
we should try to merge this and see if this makes #2676 go away for good. |
plbossart
changed the title
lyakh
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the irq_thread deals with jack removal, it modifies DAPM pin states
and then wait for workqueues to complete.
The problem is that those workqueues also modify DAPM pin states, and
the DAPM pin states may be inconsistent.
This patch suggests first waiting for scheduled workqueues to
complete before changing the DAPM pin states.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com