Repository navigation
fixup! ASoC: rt711-sdca: fix IO transfer timed out in kmod test - #2728
Merged
Merged
Conversation
The driver tries to set the SCP_SDCA_IntMask1/2 registers when the module removes. At this moment, we need to avoid accessing the registers when the cache_only enables. Therefore, this patch removes the sdw_write_no_pm when the jack sets to null. However, this is no concern because the driver disables HID 1/2 event which is controlled by the codec inside. Signed-off-by: Shuming Fan <shumingf@realtek.com>
shumingfan
requested review from
RanderWang,
jack-cy-yu and
oder-chiou
as code owners
February 1, 2021 05:48
RanderWang
approved these changes
Feb 1, 2021
bardliao
approved these changes
Feb 1, 2021
plbossart
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver tries to set the SCP_SDCA_IntMask1/2 registers when the module removes.
At this moment, we need to avoid accessing the registers when the cache_only enables.
Therefore, this patch removes the sdw_write_no_pm when the jack sets to null.
However, this is no concern because the driver disables HID 1/2 event
which is controlled by the codec inside.
Signed-off-by: Shuming Fan shumingf@realtek.com