Repository navigation
soundwire: cadence: fix race condition between suspend and Slave devi… - #2354
Merged
bardliao merged 1 commit intoAug 13, 2020
Merged
Conversation
plbossart
requested review from
RanderWang,
jack-cy-yu,
oder-chiou,
ryans-lee and
shumingfan
as code owners
August 11, 2020 16:25
ranj063
reviewed
Aug 11, 2020
plbossart
force-pushed
the
sdw/fix-alert-on-suspend
branch
from
August 11, 2020 17:52
16afa01 to
d66e70f
Compare
Member
Author
|
SOFCI TEST |
RanderWang
reviewed
Aug 12, 2020
plbossart
force-pushed
the
sdw/fix-alert-on-suspend
branch
from
August 12, 2020 14:59
d66e70f to
8c83d7c
Compare
plbossart
changed the title
Member
Author
|
@ranj063 @bardliao @RanderWang updated code and comments |
ranj063
previously approved these changes
Aug 12, 2020
ranj063
left a comment
ranj063
left a comment
Collaborator
There was a problem hiding this comment.
@plbossart looks good now. I had to read it a few times to understand the check in sdw_cdns_irq(). I think "interrupt_enabled" might make it clearer but its minor. If it is not confusing for you not a big deal for me.
…ce alerts In system suspend stress cases, the SOF CI reports timeouts. The root cause is that an alert is generated while the system suspends. The interrupt handling generates transactions on the bus that will never be handled because the interrupts are disabled in parallel. As a result, the transaction never completes and times out on resume. This error doesn't seem too problematic since it happens in a work queue, and the system recovers without issues. Nevertheless, this race condition should not happen. When doing a system suspend, or when disabling interrupts, we should make sure the current transaction can complete, and prevent new work from being queued. BugLink: thesofproject#2344 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
sdw/fix-alert-on-suspend
branch
from
August 12, 2020 17:56
8c83d7c to
8fd0a2b
Compare
Member
Author
yes, 'interrupt_enabled' sounds better, it's a state not an action. updated code, thanks for the suggestion. |
ranj063
approved these changes
Aug 13, 2020
RanderWang
approved these changes
Aug 13, 2020
bardliao
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ce alerts
In system suspend stress cases, the SOF CI reports timeouts. The root
cause is that an alert is generated while the system suspends, so on
resume the previous transaction times out.
This error doesn't seem too problematic since it happens in a work
queue, and the system recovers without issues.
Nevertheless, this should not happen. When doing a system suspend, or
when disabling interrupts, we should make sure the current transaction
can complete, and prevent new work from being queued.
BugLink: #2344
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com