Repository navigation
Conversation
commented
Jul 4, 2018
Author
|
BYT has been tested with nocodec. As respected, it works in legacy interrupt mode as HW doesn't support msi. |
lgirdwood
requested changes
Jul 5, 2018
Member
There was a problem hiding this comment.
A quick check of the PCI code shows that the PCI APIs do the msi_enabled check internally so this is check not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patches support msi in SOF.
CNL and APL have been tested.
BYT is not tested. There was a regression on byt (It's already existed for about 1 week) in SOF driver which causes SOF can't load tplg.
Other platforms don't support PCI. So no MSI patch for them.