Repository navigation
ASoC: Intel: sof_da7219_max98373: Add BE dailink for dmic16k - #1967
Merged
Merged
Conversation
Add dmic16k BE dailink for keyword detection support, FE is added in topology tplg file. Signed-off-by: Yong Zhi <yong.zhi@intel.com>
yongzhi1
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
March 31, 2020 21:24
ranj063
approved these changes
Apr 1, 2020
plbossart
approved these changes
Apr 1, 2020
marc-hb
added a commit
to marc-hb/linux
that referenced
this pull request
Apr 7, 2020
checkpatch has a --subjective (a.k.a --strict) option that enables a few additional "checks". These additional "--strict checks" are desired but - as expected from their name - their output is likely to be dismissed more frequently than other checkpatch issues. For that reason, a relatively complex post-processing Jenkins change was made on the 22nd November 2019. After that change, --strict checks were still run by Jenkins however --strict-only failures were "downgraded" to a green success. For a good example look at sof-ci/jenkins/pr-checkpatch and continuous-integration/travis-ci/pr details in PR thesofproject#1967. This small Travis PR is meant to be merged immediately after the REMOVAL of that complex checkpatch post-processing in Jenkins, swapping who dismisses strict-only failures and who doesn't. This swap is not just about replacing about 50 lines of internal Jenkins code with a couple of lines of visible code in travis and checkpatch: after this swap, a green continuous-integration/travis-ci/pr success and a red sof-ci/jenkins/pr-checkpatch failure can have only one meaning: a strict-only failure. Before this swap, no combination on the github page ever identifies a strict-only failure. Of course, it would be easier to have a real "yellow" color instead of running checkpatch twice and creatively mixing one green and one red. Unfortunately, neither Travis nor github seem to support anytihng besides red and green: travis-ci/travis-ci#4730 https://developer.github.com/v3/repos/statuses/ https://github-api.kohsuke.org/apidocs/org/kohsuke/ github/GHCommitState.html Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dmic16k BE dailink for keyword detection support, FE is
added in topology tplg file.
Signed-off-by: Yong Zhi yong.zhi@intel.com