Skip to content

ASoC: SOF: Intel: hda: call codec wake at chip init - #1932

Merged
plbossart merged 2 commits into
thesofproject:topic/sof-devfrom
kv2019i:topic/hda-use-forcewake
Mar 25, 2020
Merged

plbossart merged 2 commits into
thesofproject:topic/sof-devfrom
kv2019i:topic/hda-use-forcewake

Conversation

@kv2019i

@kv2019i kv2019i commented Mar 24, 2020

Copy link
Copy Markdown
Collaborator

Further align HDA init sequence to the legacy non-DSP HDA driver by
calling snd_hdac_set_codec_wakeup() during the chip init sequence.

One part of fix needed for #1847 (other part is a i915 driver change)

Comment thread sound/soc/sof/intel/hda-ctrl.c
Comment thread sound/soc/sof/intel/hda-ctrl.c
kv2019i added 2 commits March 25, 2020 17:07
The misc clock gating (MISCBDCGE) is disabled for controller reset and
reenabled once reset is complete.

Fix the case when error happens during reset, and clock gating is
left disabled. The clock gating should be reenabled also in this case.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Further align HDA init sequence to the legacy non-DSP HDA driver by
calling snd_hdac_set_codec_wakeup() during the chip init sequence.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
kv2019i force-pushed the topic/hda-use-forcewake branch from 94a541e to f6f98ad Compare March 25, 2020 15:25
@kv2019i
kv2019i requested a review from plbossart March 25, 2020 15:27
Comment thread sound/soc/sof/intel/hda-ctrl.c

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kv2019i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants