Skip to content

ASoC: SOF: make sof_ipc_cc_version to fixed length and fix ABI mismatch - #1890

Merged
lgirdwood merged 4 commits into
thesofproject:topic/sof-devfrom
xiulipan:pr/fixflexcc
Mar 31, 2020
Merged

lgirdwood merged 4 commits into
thesofproject:topic/sof-devfrom
xiulipan:pr/fixflexcc

Conversation

@xiulipan

@xiulipan xiulipan commented Mar 13, 2020 •

Copy link
Copy Markdown

Add probe support from thesofproject/sof#2338 ABI version 3.14.0
Add debug ABI version from thesofproject/sof#2398 ABI version 3.15.0

Align struct sof_ipc_cc_version to firmware definition in SOF ABI 3.16.0.
The struct definition was changed due to errors in FW build.
The Cadence XCC compiler produces incorrect linkage section sizes, when a
variable length array is used in the compiler version struct. The firmware
definition was changed to a fixed 32 byte compiler description string.
This length covers all released firmware binaries and thus only a minor
ABI change is needed.

As the same structure is used in IPC messages between driver and firmware,
the kernel needs to be aligned to firmware change.

Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com

FW change is thesofproject/sof#2522

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI involves ABI changes, need extra attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants