Repository navigation
ASoC: SOF: Intel: add codec_mask module parameter - #1551
Conversation
Add a module parameter 'codec_mask' to filter out unwanted HDA codecs from driver probe. E.g. on most systems, codec_mask=4 will limit to HDMI audio and exclude any external HDA codecs. Similar to 'probe_mask' module parameter of snd-hda-intel. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
LGTM
wondering if we can extend this so that with Kconfig selections you can remove iDISP or regular HDaudio directly.
|
@plbossart wrote:
I thought about that, but the addresses can (at least in theory) vary from system to another, so hardcoding them to kconfig does not seem good. And passing raw mask values via kconfig seems like a very low-level developer option -- we could still add it though, but will need to hide it in the developer options menu at least. Another limitation we currently have is that if I block the HDMI codec (e.g. set codec_mask=1), our SOF probe will now fail as the generic machine driver code only understands the special case where num_codecs==1 and that one codecs is HDMI. Can be of course fixed, but is a limitation to be aware of at least. But switching between HDMI-only and all-HDA is pretty convenient now. Just edit modprobe rules, reload driver and you are done. No kernel recompile or reboot needed. I'm using following now: #options snd_sof_intel_hda_common codec_mask=0x4 If I uncomment this, one gets a HDMI-only config. Commented out, you get the full HDA setup again. This is pretty nice. |
3 participants
Add a module parameter 'codec_mask' to filter out unwanted
HDA codecs from driver probe. E.g. on most systems,
codec_mask=4 will limit to HDMI audio and exclude any
external HDA codecs.
Similar to 'probe_mask' module parameter of snd-hda-intel.
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com