Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of patches expose one of the core debug features for DSP:
probes. Probes can be treated as endpoints which allow for data
extraction from or injection to target module. This is paramount when
debugging problematic audio issues such as distortions, glitches or gaps.
Compress streams are a weapon of choice here to provide a lightweight
implementation.
As SOF ipc framework is directly based on /skylake's one, it shares some of its problems. Host can never known upfront size of payload returned by a getter e.g. PROBE_DMA_GET or PROBE_POINT_GET, it can only estimate. Because of this, quick hack has been added to permit PROBE ipcs to work despite non-matching size.
Another point of contention are probe/ compress operations themselves. As these are basically made of hdac_foos and IPCs only, I decided to make this feature Intel specific for now.
_copy function assignment ain't in best place either - due to reason presented above, I've delegated assignment to dbg_init, what again, can be called a hack.