Repository navigation
Conversation
Initial support for ALC/RT700 in SoundWire mode This codec is present on Intel CNL/CML and ICL RVP boards and the code was tested by both Realtek and Intel. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Shuming Fan <shumingf@realtek.com>
The driver for this amplifier was tested by Realtek and Intel using the Realtek 3-in-1 add-on boards connected to CometLake and IceLake platforms Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Shuming Fan <shumingf@realtek.com>
The driver for this codec was tested by Realtek and Intel using the Realtek 3-in-1 add-on board connected to CometLake and IceLake platforms. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Shuming Fan <shumingf@realtek.com>
The driver for this capture device was tested by Realtek and Intel using the Realtek 3-in-1 add-on boards connected to CometLake and IceLake platforms Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Jack Yu <jack.yu@realtek.com>
Don't push upstream Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Somehow rt711_set_jack_detect() will not be called again even we return -EAGAIN. It is better to do jack init in rt711_io_init() if rt711_set_jack_detect() is called before rt711 is attached. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Collaborator
Author
|
@shumingfan Could you help to review? |
shumingfan
reviewed
Sep 26, 2019
| /* power off */ | ||
| if (dapm->bias_level <= SND_SOC_BIAS_STANDBY) | ||
| regmap_write(rt711->regmap, | ||
| RT711_SET_AUDIO_POWER_STATE, AC_PWRST_D3); |
There was a problem hiding this comment.
@bardliao Could you move the power on/off to rt711_jack_init function?
It has a chance to be power off state when running rt711_jack_init function.
plbossart
force-pushed
the
integration/realtek-sdw-codecs
branch
2 times, most recently
from
September 26, 2019 16:09
715f052 to
c0b65b4
Compare
|
@bardliao I submitted a new PR for this issue. Please check PR#1260. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow rt711_set_jack_detect() will not be called again even we
return -EAGAIN.
It is better to do jack init in rt711_io_init() if
rt711_set_jack_detect() is called before rt711 is attached.
Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com