Repository navigation
[v5.0 release] ALSA: hda: fix headphone detection failed - #1060
Closed
RanderWang wants to merge 1 commit into
Closed
RanderWang wants to merge 1 commit into
RanderWang wants to merge 1 commit into
Conversation
In ASoC, cmd io is diabled when there is no user on the bus and is enabled when a user is active. But unsolicated event is diabled in snd_hdac_bus_stop_cmd_io and not enabled in snd_hdac_bus_init_cmd_io. This makes headphone detection failed. This patch Enable unsolicated event when cmd io is enabled. Tested on whiskylake with legacy hda driver and SOF driver Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
RanderWang
changed the title
Author
|
This patch is requested by canonical. And I will send it to ALSA mail list later. |
|
is the patch legitimate on sof-dev? If so, please remove the [] prefix. + more reviewers |
Author
Not now, it is only for v5.0 release. I sent this patch to ALSA mail list and Takashi approved. I will create a PR for sof-dev after it is merged. |
Collaborator
Blindly merged to release/sof-v5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ASoC, cmd io is diabled when there is no user on
the bus and is enabled when a user is active. But unsolicated
event is diabled in snd_hdac_bus_stop_cmd_io and not
enabled in snd_hdac_bus_init_cmd_io. This makes headphone
detection failed.
This patch Enable unsolicated event when cmd io is enabled.
Tested on whiskylake with legacy hda driver and SOF driver
It fixes #1055 #1054
Signed-off-by: Rander Wang rander.wang@linux.intel.com