Repository navigation
Conversation
This reverts commit 0ce7065.
Signed-off-by: Libin Yang <libin.yang@intel.com>
Signed-off-by: Libin Yang <libin.yang@intel.com>
ranj063
reviewed
Jun 6, 2019
| goto free_hda_irq; | ||
| } | ||
| ret = request_irq(hdev->irq, my_irq_handler, | ||
| IRQF_SHARED, "AudioHDA", sdev); |
Collaborator
There was a problem hiding this comment.
@libinyang why IRQF_SHARED if we're merging them?
ranj063
reviewed
Jun 6, 2019
| // goto again; | ||
| status = snd_hdac_chip_readl(bus, INTSTS); | ||
| if (status & AZX_INT_CTRL_EN) | ||
| goto again; |
Collaborator
There was a problem hiding this comment.
@libinyang is this looping really needed even after you merged the handlers?
Member
|
closing, this doesn't seem like a PR that will ever be merged as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patchset is trying to fix the ipc timeout issue and merging 2 irq hander into one handler (stream irq handler and ip irq handler)