Skip to content

pcm suspend/resume cleanup #570

Closed
Closed

Description

@keyonjie

we should do it like this:
suspend:

  1. send stream trigger stop IPC(to FW) in sof_pcm_trigger() when TRIGGER_SUSPEND arrive, and mark spcm->restore_stream[] to be true;
  2. (after multiple ssp and icelake support #1 done for all PCMs) send suspend IPC(context_save) to FW, and suspend ADSP.

resume:

  1. send resume IPC(context_restore) to FW (after FW rebooted).
  2. send stream trigger start IPC(to FW) in sof_pcm_trigger() when TRIGGER_RESUME arrive(if spcm->restore_stream[] is true), and mark spcm->restore_stream[] back to be false;

But now this is messed, we need cleanup it.

Activity

  1. keyonjie commented on Jan 21, 2019

    @keyonjie
    Author

    @ranj063 can you do this?

  2. plbossart commented on Jan 22, 2019

    @plbossart
    Member

    @keyonjie can you try to be clearer in the description of issues? "this is messed [up]" does not describe what we are currently doing wrong and what your proposal solves.
    remember the 3 steps:

    • what is the issue (visible/side effects)
    • why the issue happens (root cause)
    • how we can solve it (proposal).
      Also why is this an "enhancement"?
  3. ranj063 commented on Jan 22, 2019

    @ranj063
    Collaborator

    @plbossart @keyonjie I am already working on this. This change is for addressing the following issue:
    #489
    thesofproject/sof#788

  4. self-assigned this
    on Jan 22, 2019
  5. ranj063 commented on Feb 2, 2019

    @ranj063
    Collaborator

    Fixed by #582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions