Repository navigation
Driver support for firmware recovery #452
Description
When the firmware gets stuck or unresponsive (IPC timeouts), the driver just bails out and the only way to recover is to reboot. That's not acceptable for a number of products.
The SOF driver needs to implement a recovery mechanism where it detects the firmware has gone off tracks (e.g. with a 5s watchdog), and restores the configuration (hardware reset, firmware download, pipelines and controls restored). We already have this sequence for resume so it shouldn't be too hard.
Note that this request is not asking for seamless operation. Applications will likely time out and likely stop, so collaboration with userspace is likely required to reenable playback/capture. The ask is really to avoid a reboot and restart cleanly.
Activity
wenqingfu commentedon Dec 17, 2018
extended work of thesofproject/sof#710?
plbossart commentedon Dec 17, 2018
ranj063 commentedon Dec 21, 2018
@plbossart looking into the hda_dsp_core_reset_power_down() method in hds-dsp.c, we seem to be placing the core in reset before powering down and when the firmware is unresponsive, this also seems to fail. This is required when we want to shutdown gracefully.
In the case of panic, would it be acceptable to just power down the cores instead of placing them in reset?
plbossart commentedon Dec 21, 2018
xiulipan commentedon Feb 10, 2019
@plbossart @ranj063
Actually now when a panic happened. If runtime_pm is not disabled, it will automatically recovery the DSP by runtime_suspend and runtime_resume.
This now brings some difficulty in debug as all the logs and dumped exception info is gone with that suspend/resume.
As for the recovery mode, I think we may need to add flag or debugfs controller to disable the FW recovery for DEBUG usage.
plbossart commentedon Feb 11, 2019
wenqingfu commentedon Apr 1, 2019
@kv2019i , would you be able to take this one? thanks!
kv2019i commentedon Apr 2, 2019
@wenqingfu wrote:
Ack. I'm currently looking at tracing issues during suspend and runtime supsned (old issue #248
and newer #486), will work on these first (good way to learn the tracing part first) and then move to this.
kv2019i commentedon Apr 17, 2019
Hello, I now pushed initial patchset to address this issue (PR841). I ended up taking a slightly different path than what you've discussed earlier, so please check the code and see whether this is on the right track or not.
bpf, sockmap: Don't sleep while holding RCU lock on tear-down
kv2019i commentedon May 19, 2021
@ujfalusi got #1675 so passing this as well :)
Fixed build WARNINGs
plbossart commentedon Aug 12, 2024
duplicate of #1675
arch: Reserve map_shadow_stack() syscall number for all architectures