Skip to content

HDMI: rework the code to align with upstream fixes #400

Closed

Description

@plbossart

Takashi just posted a set of patch on alsa-devel: ALSA: HD-audio display power fixes
We need to rework the code and make sure the i915 power management remains functional.
Yet another example of why we need to upstream faster.

Filing as a bug since it'll gate upstream merges.

Activity

  1. mengdonglin commented on Dec 11, 2018

    @mengdonglin
  2. plbossart commented on Dec 11, 2018

    @plbossart
    MemberAuthor
  3. bardliao commented on Dec 12, 2018

    @bardliao
    Collaborator

    @plbossart I didn't have time to check v2 version today. But I did a basic test on v1. snd_hdac_display_power() is changed so we need to modify hda-codec.c to adapt the change .After that hdmi playback works on Up2.

  4. ranj063 commented on Dec 12, 2018

    @ranj063
    Collaborator

    @bardliao after you finish your changes, please ensure it doesnt also break PM functionality on chrome.

  5. bardliao commented on Dec 13, 2018

    @bardliao
    Collaborator

    @ranj063 Sure. But will chrome apply these patches?

  6. plbossart commented on Dec 13, 2018

    @plbossart
    MemberAuthor

    @ranj063 Sure. But will chrome apply these patches?

    If they don't then it's their decision and the Chrome integration team will have to modify the HDMI code on SOF to use the old snd_hdac_display_power and deal with reference counts. we stick to upstream in topic/sof-dev

  7. plbossart commented on Dec 16, 2018

    @plbossart
    MemberAuthor

    @bardliao can you submit a PR with Takashi's v2 changes (make sure to use cherry-pick -x so that we track upstream) and the changes needed on the SOF sides? I will need to other changes from upstream but this needs to go into topic/sof-dev first, otherwise I'll break the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1Blocker bugs or important featuresbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions