Skip to content

[SoundWire] Kernel Oops on machine/codec driver remove #3531

Closed
Closed
[SoundWire] Kernel Oops on machine/codec driver remove#3531
Labels
P1Blocker bugs or important featuresSDWApplies to SoundWire bus for codec connectionbugSomething isn't working

Description

@pablos-here
pablos-here
opened on Mar 21, 2022

Describe the bug
I was attempting to configure the sound card on my Dell XPS 9700 as the mic was not working (speakers work). This resulted in a kernel call trace which I submitted a bug against[1] against my distro.

I distilled the developer's test case so blame me for non-intuitive cruft. There are two conditions which cause the oops - see below.

Just in case, I have captured separately the call trace for each condition.

I'm also uploading alsa-info.txt.

Refernces
1 - https://bugzilla.suse.com/show_bug.cgi?id=1197315

Condition 1

/sbin/modprobe -r snd_soc_sof_sdw
/sbin/modprobe -r snd_soc_rt711

Condition 2

# 
# Run me twice
# 
/sbin/modprobe -r snd_soc_sof_sdw
/sbin/modprobe -r snd_soc_rt1308_sdw

Call trace per condition
condition-1.txt
condition-2.txt

Activity

  1. plbossart commented on Mar 21, 2022

    @plbossart
    plbossart
    on Mar 21, 2022
    Member

    @looney-loon Can you try and remove the parent PCI device first to see if this helps? this is what we do in our remove/insert tests. I am not sure if we've ever tested removing the machine driver this way.

    /sbin/modprobe -r snd_sof_pci_intel_cnl
/sbin/modprobe -r snd_soc_sof_sdw
/sbin/modprobe -r snd_soc_rt711
/sbin/modprobe -r snd_soc_rt1308_sdw
```

  2. plbossart commented on Mar 21, 2022

    @plbossart
    plbossart
    on Mar 21, 2022
    Member

    For reference, these are the scripts we use:

    https://github.com/thesofproject/sof-test/blob/main/tools/kmod/sof_remove.sh
    https://github.com/thesofproject/sof-test/blob/main/tools/kmod/sof_insert.sh

  3. plbossart
    added 2 commits that reference this issue on Mar 22, 2022

    soundwire: bus_type: reset pointers on remove and shutdown

    63f074a

    soundwire: bus_type: reset pointers on remove and shutdown

    8274036

  4. plbossart commented on Mar 22, 2022

    @plbossart
    plbossart
    on Mar 22, 2022
    Member

    I can reproduce the problem, see tentative fix at 8274036 PR #3534

  5. plbossart
    changed the title [-]Oops > trying to configure audio[/-] [+][SoundWire] Kernel Oops on machine/codec driver remove[/+] on Mar 22, 2022
  6. plbossart
    added
    SDWApplies to SoundWire bus for codec connection
    bugSomething isn't working
    P1Blocker bugs or important features
    on Mar 22, 2022

  7. pablos-here commented on Mar 22, 2022

    @pablos-here
    pablos-here
    on Mar 22, 2022
    Author

    Can you try and remove the parent PCI device first to see if this helps? this is what we do in our remove/insert tests. I am not sure if we've ever tested removing the machine driver this way.

    /sbin/modprobe -r snd_sof_pci_intel_cnl
/sbin/modprobe -r snd_soc_sof_sdw
/sbin/modprobe -r snd_soc_rt711
/sbin/modprobe -r snd_soc_rt1308_sdw

    Hi Pierre-Louis,

    I just tested the commands above and it works. I'll update the SUSE bug.

    Glad the issue netted something productive on your end.

    Let me know if you'd like me to close the issue or whether your workflow handles it.

    Merci beaucoup!

  8. plbossart
    added a commit that references this issue on Mar 22, 2022

    soundwire: bus_type: reset pointers on remove and shutdown

    82d64fb
  9. plbossart
    added 3 commits that reference this issue on Apr 5, 2022

    soundwire: use driver callbacks directly with proper locking

    40d0b69

    soundwire: use driver callbacks directly with proper locking

    59691ba

    soundwire: use driver callbacks directly with proper locking

    ec64f4c
  10. intel-lab-lkp
    added a commit that references this issue on Apr 7, 2022

    soundwire: use driver callbacks directly with proper locking

    72c38af

  11. 100 remaining items

  12. ammarfaizi2
    added 9 commits that reference this issue on Aug 16, 2022

    soundwire: revisit driver bind/unbind and callbacks

    447ce07

    soundwire: revisit driver bind/unbind and callbacks

    20efc93

    soundwire: revisit driver bind/unbind and callbacks

    cbb426c

    soundwire: revisit driver bind/unbind and callbacks

    3c4e362

    soundwire: revisit driver bind/unbind and callbacks

    f02522d

    soundwire: revisit driver bind/unbind and callbacks

    f62f865

    soundwire: revisit driver bind/unbind and callbacks

    62885c0

    soundwire: revisit driver bind/unbind and callbacks

    b3e34a4

    soundwire: revisit driver bind/unbind and callbacks

    2ca6939
  13. Whissi
    added a commit that references this issue on Aug 17, 2022

    soundwire: revisit driver bind/unbind and callbacks

    250b465
  14. woodsts
    added a commit that references this issue on Aug 17, 2022

    soundwire: revisit driver bind/unbind and callbacks

    8fd6b03
  15. Whissi
    added a commit that references this issue on Aug 17, 2022

    soundwire: revisit driver bind/unbind and callbacks

    432b30f
  16. psndna88
    added a commit that references this issue on Aug 19, 2022

    soundwire: revisit driver bind/unbind and callbacks

    7cc1824
  17. tuxedo-bot
    added a commit that references this issue on Oct 7, 2022

    soundwire: revisit driver bind/unbind and callbacks

    ca77b7c
  18. tuxedo-bot
    added a commit that references this issue on Oct 19, 2022

    soundwire: revisit driver bind/unbind and callbacks

    7a523ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Blocker bugs or important featuresSDWApplies to SoundWire bus for codec connectionbugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions