Skip to content

[FEATURE] use NHLT to detect which SSP is used for devices with ES8336 #3337

Closed

Description

@plbossart

So far we've never needed to guess what SSP was used, it was known by design for Chromebooks and SSP was never used in devices designed for Windows.

Devices with ES8336 break that assumption, they support Windows but also use I2S/SSP. We may need to use the NHLT information, if present, to detect what SSP to use in the machine driver and topology.

Activity

  1. plbossart commented on Dec 14, 2021

    @plbossart
    MemberAuthor

    @hli25 could you try to dump the NHLT tables used in the GLK and TGL devices you used?

  2. plbossart commented on Dec 14, 2021

    @plbossart
    MemberAuthor

    @hli25 could you try to dump the NHLT tables used in the GLK and TGL devices you used?

    I meant just dump the ACPI tables with 'sudo acpidump > dump.bin', for NHLT a newer version 20210930 acpica-tools version is needed.

  3. hli25 commented on Dec 15, 2021

    @hli25
  4. yangxiaohua2009 commented on Dec 15, 2021

    @yangxiaohua2009

    @hli25 @plbossart we have glk, cml, cfl 8336 and 8326 tgl devices. DUMP.zip

  5. plbossart commented on Dec 15, 2021

    @plbossart
    MemberAuthor

    Thanks @yangxiaohua2009.

    I wasn't able to parse the CFL table.

    For CML and TGL I see SSP0 being used.
    For GLK I see SPP2 being used.

  6. plbossart commented on Jan 17, 2022

    @plbossart
    MemberAuthor

    solution implemented in #3338

    The only problem is that we need quite a few topology files, see
    es8336-topologies-2.tar.gz
    and it would be preferable to override a default SSP from the machine driver.

  7. plbossart commented on Jun 29, 2022

    @plbossart
    MemberAuthor

    feature completed and upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions