runtime suspend/resume doesn't work when no hdmi pipelines defined in tplg file(with idisp BEs defined in machine driver).

it can't enter suspend as hdmi codec driver is always waiting for hdmi codec probing.

@keyonjie

@keyonjie thanks for report. Can you please add more details so that people can reproduce your finding?

@keyonjie

@keyonjie this issue has not been updated since October 31, 2018, there is no description of the issue. Should it be closed or is this still open?

@keyonjie

@keyonjie I've tested this on my up2 board to see if this is still an issue (per @ranj063 recommendations) I'm not seeing the issue you mentioned, but full disclosure, I couldn't replicate the issue as described either.

I tested sof-apl-pcm512x.tplg from latest topic/sof-dev built with and without HDA.

I've included two files - each containing data from one of the runs:
dmesg logs + the output from 'cat /proc/asound/pcm' + the output of alias
pcm_status="cat /sys/bus/pci/devices/0000\:00\:0e.0/power/runtime_status"

pcm_dmesg_with-HDA.txt
pcm_dmesg_no-HDA.txt

@stripes416

@stripes416 @zhuyingjiang the issue happened at when there is no hdmi/idisp pcm defined in tplg file, it was firstly found by @bardliao iirc, Bard and Libin did some work on that, I am not sure if it is already fixed in the latest code base, Can you comment out these in sof-apl-pcm512.m4 and retry if you can enter suspend?

# Low Latency playback pipeline 2 on PCM 1 using max 2 channels of s32le.
# Schedule 48 frames per 1000us deadline on core 0 with priority 0
PIPELINE_PCM_ADD(sof/pipe-volume-playback.m4,
        2, 1, 2, s32le,
        48, 1000, 0, 0)

# Low Latency playback pipeline 3 on PCM 2 using max 2 channels of s32le.
# Schedule 48 frames per 1000us deadline on core 0 with priority 0
PIPELINE_PCM_ADD(sof/pipe-volume-playback.m4,
        3, 2, 2, s32le,
        48, 1000, 0, 0)

# Low Latency playback pipeline 4 on PCM 3 using max 2 channels of s32le.
# Schedule 48 frames per 1000us deadline on core 0 with priority 0
PIPELINE_PCM_ADD(sof/pipe-volume-playback.m4,
        4, 3, 2, s32le,
        48, 1000, 0, 0)

I verified on Up2 with sof-apl-pcm512x-nohdmi.tplg, the Up2 can normally do suspend/resume. So we can close this issue.

@zhuyingjiang

good, thanks @zhuyingjiang and @stripes416

@zhuyingjiang

@zhuyingjiang & @keyonjie Thanks!

Merge pull request thesofproject#234 from Kloenk/improved_macro

ksmbd: set ATTR_CTIME flags when setting mtime

riscv: Fix sleeping in invalid context in die()

selftests/bpf: Add mprog API tests for BPF tcx links

selftests/bpf: Add various more tcx test cases

net: pktgen: fix code style (WARNING: macros should not use a trailin…

Navigation Menu

Repository navigation

runtime suspend/resume doesn't work when no hdmi pipelines defined in tplg file(with idisp BEs defined in machine driver). #234

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

runtime suspend/resume doesn't work when no hdmi pipelines defined in tplg file(with idisp BEs defined in machine driver). #234

Description

Activity

plbossart commented on Oct 31, 2018

plbossart commented on Mar 24, 2019

stripes416 commented on Apr 10, 2019

keyonjie commented on Apr 11, 2019

zhuyingjiang commented on Apr 11, 2019

keyonjie commented on Apr 11, 2019

stripes416 commented on Apr 11, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions