Repository navigation
Clean up SOF FW booting in driver #1179
Description
In general, we have several flags which are FW booting related in struct snd_sof_dev, that is .boot_complete, .boot_wait, .code_loading, .waitq, we need to clean up them, e.g. to use only one or two, we need define clear steps and states during FW booting(until the FW_READY message received and boot finished).
-
try if we can abandon the use of sdev->waitq and sdev->code_loading. please make sure it can works on cAVS 1.5/1.8/2.0+ platforms.
The thought is from: ASoC: SOF: Intel: improve irq thread in handling empty message interrupt from firmware loader #916 (comment) -
change boot_complete to be boot_state, and it can be enumerated as BOOT_INIT, BOOT_ONGOING, BOOT_FAILED, BOOT_SUCCESS.
And then in the place boot failed, set boot_state to BOOT_FAILED, in IPC handling, handle fw_ready message only at BOOT_ONGOING stage.
The thought here is from: ASoC: SOF: loader: fix kernel oops on firmware boot failure #1174 (comment)
Activity
plbossart commentedon Mar 3, 2020
@keyonjie I think we implemented everything listed in this enhancement, can we close?
aiChaoSONG commentedon Mar 4, 2020
@plbossart We still need to remove some redundant code:
keyonjie commentedon Mar 4, 2020
@plbossart I think the item 2 had already done by @ranj063 , for item 1, @aiChaoSONG can you re-activate and proceed your PR please?
aiChaoSONG commentedon Mar 4, 2020
@keyonjie The PR for item 1 is here #1854.
keyonjie commentedon Mar 6, 2020
@aiChaoSONG good, can you do the item 2 you listed above also?
aiChaoSONG commentedon Mar 9, 2020
@keyonjie PR for item 2 is here: #1875
aiChaoSONG commentedon Mar 13, 2020
closed for all done in the list
bonding: fix suspicious RCU usage in bond_ipsec_offload_ok()