Skip to content

Pod 11741/ci block builds if secrets detected - #2

Open
stoychost wants to merge 7 commits into
theflow:masterfrom
podio:POD-11741/CI-block-buids-if-secrets-detected
Open

stoychost wants to merge 7 commits into
theflow:masterfrom
podio:POD-11741/CI-block-buids-if-secrets-detected

Conversation

@stoychost

Copy link
Copy Markdown

WHAT

Removes the blank line before #!/usr/bin/env groovy in the Jenkinsfile.

WHY

Jenkins only accepts a shebang on line 1. With the leading blank line the pipeline
failed to compile (unexpected char: '#' at line 2), so no CI ran for this repo,
including the TruffleHog secret scan required by POD-11741.

RISK

Low. One-line whitespace change; no build logic changes. The repo keeps
securityScanOnly = true and the aws-linuxdocker-test node.

TESTING

  • Branch build on the new "Build Simpleconfig app" multibranch job compiled and ran on aws-linuxdocker-test.
  • Replayed with the strict template (jenkins-template-repo POD-11741): TruffleHog ran with
    --results=verified,unknown,unverified --fail, scanned 330 chunks, 0 verified / 0 unverified findings.
    No .trufflehog-known-findings needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants