Repository navigation
Clean up automatically when container stopped #552
Description
Hi, is there a way to properly clean up once container stopped?
Would be good to have it as a setter in GenericContainer.
It could rely on this
Hi, is there a way to properly clean up once container stopped?
Would be good to have it as a setter in GenericContainer.
It could rely on this
Activity
bsideup commentedon Jan 22, 2018
hi @alexcase52,
Do you want it to be cleaned during the tests or after?
alexcase52 commentedon Jan 22, 2018
Immediately once the container stopped is better for me - it may retain some space. But usually it is no so important when.
kiview commentedon Jan 23, 2018
We already have such a functionality in place (Reaper) and we will soon add a more reliable component for this running outside the JVM.
What functionality are you missing with the current implementation?
alexcase52 commentedon Jan 23, 2018
OK if you already have it. I just see some strange exited containers appeared after I started experiments with testcontainers. In my case there were postgres containers.
kiview commentedon Jan 23, 2018
This will currently happen if you i.e. SIGKILL the JVM process.
alexcase52 commentedon Jan 23, 2018
Maybe I had this case and some guard here is desirable. Quite often I could terminate tests e.g. while debugging if I see that something failed and I've got what was wrong. Not sure how this docker --rm flag will behave.
bsideup commentedon Jan 23, 2018
@alexcase52
Bad news:
--rmdoesn't help (trykill -9yourdocker run --rm:) )Good news: we're going to handle that! :) See #545 for the details, to be released soon
alexcase52 commentedon Jan 23, 2018
Thanks, will wait for this change
iNikem commentedon Jan 30, 2018
I believe this can be closed now as #545 is released in 1.6.0
kiview commentedon Jan 30, 2018
Closed by #545