Repository navigation
GenericContainer tries to talk to remote registry too soon (during instance initialization) #302
Description
I'm running tests on a machine that doesn't currently have connectivity to the Docker Hub. Certainly, I expect TestContainer-based cases to fail in that case. So I have written a JUnit rule to conditionally disable these test cases when a certain configuration setting has been made, and write something like this in my test case:
public static ConditionalIgnore skip =
ConditionalIgnore.needsDocker(ConfigFactory.load("test"));
// VaultContainer is my own subclass of GenericContainer
public static VaultContainer VAULT = new VaultContainer();
@ClassRule
public static final RuleChain rules = RuleChain.outerRule(skip)
.around(VAULT);
The problem I'm seeing is, however, that this requires instantiating the VaultContainer class, which will call the GenericContainer constructors, and those constructors will actually try to talk to the Docker Hub:
Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image name from org.testcontainers.images.RemoteDockerImage@4a0952ab
at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:711)
at org.testcontainers.containers.GenericContainer.setDockerImageName(GenericContainer.java:699)
at org.testcontainers.containers.GenericContainer.<init>(GenericContainer.java:145)
at com.progressfin.foundation.secret.VaultContainer.<init>(VaultContainer.java:33)
at com.progressfin.foundation.secret.VaultContainer.<init>(VaultContainer.java:29)
at com.progressfin.foundation.secret.VaultSecretsTest.<clinit>(VaultSecretsTest.java:30)
... 40 more
Caused by: org.testcontainers.shaded.com.github.dockerjava.api.exception.InternalServerErrorException: {"message":"Get https://registry-1.docker.io/v2/: read tcp 1.2.3.4:54526->4.3.2.1:443: read: connection reset by peer"}
The problem is here (line numbers don't match up because the stack trace is from 1.1.6):
There's a very interesting comment there ("Mimic old behavior where we resolve image once it's set") that tells us that this behavior is intentional. What I would suggest is that the behavior is at odds with the sort of uses that JUnit rules are meant to support; the test rule should arguably take no "risky" actions at all unless the Statement is actually invoked, i.e. in the GenericContainer.start() method, which already does call the getDockerImageName() method anyway. (And is it just me, or is it also weird that a String getter like getDockerImageName() would talk to the network?)
Activity
bsideup commentedon Mar 2, 2017
@ldcasillas-progreso this is something I want to change as well, yes :) You just hit the leftover from a change to allow Dockerfiles.
However, this is a breaking change, and we have to target 2.x milestone for it.
Good news - we're going to start 2.x soon :)
As a workaround, you can use
testcontainers-java/core/src/main/java/org/testcontainers/containers/GenericContainer.java
Lines 153 to 155 in 935a2db
ldcasillas-progreso commentedon Mar 2, 2017
@bsideup Thanks for the workaround! It definitely helped in our narrow case, but I would observe that I still see TestContainers (now upgraded to 1.1.9) doing some stuff:
I haven't tried running in a system without Docker, so I didn't establish whether this would cause a failure in that case.
rnorth commentedon Jun 4, 2017
Relates to #343
stale commentedon Oct 28, 2018
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.