Skip to content

Starting stack should fail if an DC error occurs #147

Closed

Description

@monowai

The DockerComposeContainer continued to try the stack despite a configuration error in the YML. Starting from the command line yielded:
ERROR: Validation failed in file './docker-compose.yml', reason(s)

Can DCC fail the test the test if it encounters such a fatal condition as docker-compose does when starting from the command line?

Activity

  1. rnorth commented on May 21, 2016

    @rnorth
    Member

    Hi
    I'm working on this, together with #146, to make some fairly major alterations to the docker compose support. My intention is to fix the currently slightly awkward abstraction of the DockerComposeContainer class being a container object in its own right: really, it should be a class that invokes containerized docker-compose as and when necessary to bring up the environment.

    This should open more opportunities for cleaning up the logs output, amongst other improvements.

    Richard

  2. rnorth commented on Jun 5, 2016

    @rnorth
    Member

    Refactoring continues on branch - still not implemented fail-fast for docker-compose errors yet I'm afraid.

  3. self-assigned this
    on Jul 2, 2016
  4. modified the milestone: 1.1.0 on Jul 2, 2016
  5. modified the milestone: 1.1.0 on Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions