Conversation
Evanthx
force-pushed
the
link_converter
branch
from
September 18, 2026 22:38
8d7117a to
5a5a0e7
Compare
tconley1428
reviewed
Sep 28, 2026
Evanthx
force-pushed
the
link_converter
branch
from
September 29, 2026 20:42
682fa1d to
f3429e4
Compare
Evanthx
force-pushed
the
link_converter
branch
from
October 2, 2026 17:40
f3429e4 to
a79da94
Compare
VegetarianOrc
approved these changes
Oct 2, 2026
VegetarianOrc
left a comment
VegetarianOrc
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Couple nits but nothing major.
Comment on lines
+60
to
+66
| def _link_path_regex(path: _LinkPath) -> re.Pattern[str]: | ||
| run_id = "[^/]+" if path.run_id_required else "[^/]*" | ||
| tail = f"/{path.tail}" if path.tail else "" | ||
| return re.compile( | ||
| rf"^/namespaces/(?P<namespace>[^/]+)/{path.keyword}" | ||
| rf"/(?P<id>[^/]+)/(?P<run_id>{run_id}){tail}$" | ||
| ) |
Contributor
There was a problem hiding this comment.
small nit, but could/should this be a method on _LinkPath?
| ) -> tuple[dict[str, str], dict[str, list[str]]] | None: | ||
| def _parse_link_url( | ||
| link: nexusrpc.Link, link_type: _LinkType | ||
| ) -> tuple[str, str, str, dict[str, list[str]]] | None: |
Contributor
There was a problem hiding this comment.
nit here as well: I think I'd prefer a frozen dataclass over the tuple of many things.
VegetarianOrc
approved these changes
Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Unified the Link Converter code - modelling what was done for Java and bringing into the other SDKs:
temporalio/sdk-java#3068
There are multiple encoding and decoding methods for links, all pretty close but not quite. That had me worried as it is easy for them to get out of sync. This PR should be no functional changes, but merges those methods.
I also compared the behavior across the other SDKs, and am unifying them - a few edge cases didn't quite match up. Testing was added around these edge cases.
Changes in Python SDK behavior are: