Repository navigation
refactor(agents): discover skill context with Go - #796
Draft
tbhb-agent wants to merge 2 commits into
Draft
tbhb-agent wants to merge 2 commits into
tbhb-agent wants to merge 2 commits into
Conversation
tbhb-agent
added
the
provenance:agent-assisted
Skill callers need to distinguish an absent capability from a failed lookup. Buffer supported responses before exposing a value so Git and checksum failures can't select a shell fallback or leak partial data. Keep older binaries on the existing shell path without raising the binary floor. Preserve worktree readiness refusals and session precedence while leaving trust and downloads to the operator. Assisted-by: codex:gpt-6.1-sol Signed-off-by: Tony Burns <tony@tonyburns.net>
Windows path joining changes the spelling returned by Git. Git Bash also converts literal arguments before a native command reads them. Preserve the shell strings that existing callers expect from discovery. Use the sourcing shell's home spelling for expansion without overriding `HOME` in native child processes. Assisted-by: codex:gpt-6.1-sol Signed-off-by: Tony Burns <tony@tonyburns.net>
tbhb-agent
force-pushed
the
feat/755-20261026
branch
from
October 27, 2026 02:39
1803548 to
603b126
Compare
tbhb-agent
added
the
change:chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the agentrepo context command for repository, worktree, harness, and session discovery. Buffer responses and reject failed or incomplete output. Keep the existing shell path for binaries without the command.
Why
A failed Git or checksum lookup must stop discovery without exposing a partial value or selecting a fallback. Existing consumers need the shell path until #772 removes it.
Verification
mise run test-hooks tests/skills/source/libcontext.HEAD, linked worktree, harness, and session discovery match the shellmise run test-hooks tests/skills/source/libmise run test-hooks tests/skills/source/libmise run test-hooks tests/skills/source/libmise run check-generated-skillsmise run lintRisk
Skill gates depend on discovery. Accepting a failed response could hide an error. Caller fixtures exercise that boundary. Revert this change to restore the previous behavior.
Compatibility: none
Related
Closes #755. Part of #588. Merges after #753. Issue #772 owns fallback removal.