Repository navigation
Remove distinct - #340
Remove distinct#340vvmsalat wants to merge 2 commits into
Conversation
Removed distinct method to maintain multiple attribute handling when filtering by params. See: taskadapter#339
|
can you please add/update tests for this change? |
|
@vvmsalat this seems to be a useful change. let's add tests for it? |
| return origParams | ||
| .stream() | ||
| .filter(Objects::nonNull) | ||
| .collect(Collectors.toMap(RequestParam::getValue, a -> a, (s1, s2) -> s1)) |
There was a problem hiding this comment.
@alexeyOnGitHub like this, different
RequestParam{name='f[]', value='status_id'
RequestParam{name='f[]', value='cf_13' can be filtered, which is total need.
Still, if ever duplicate values occure, the map would skip one entry. Ideally the key/value pair should be duplicate checked.
But that's it for the moment.
alexeyOnGitHub
left a comment
alexeyOnGitHub
left a comment
There was a problem hiding this comment.
this is not a correct fix. it will drop all parameters with the same values. I added a test in "master" branch to demonstrate the problem.
|
please see the comments above - this change would introduce a bug into the library. closing this PR because there weren't any changes in it in about a year. |
Removed distinct method to maintain multiple attribute handling when filtering by params.
See: #339