You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add ability to obtain null value with SingleValueConverter #369
Although I don't like the idea of passing a list of converters simultaneously (that gives some ambiguity about the order of these converters in the stack), I agree with this bugfix in general.
Activity
ArtDu commentedon Mar 20, 2023
Proposal how it could be
public TarantoolResultMapper<TarantoolTuple> withArrayValueToTarantoolTupleResultConverter( ArrayValueToTarantoolTupleConverter tupleConverter) { - return withConverterWithoutTargetClass( - messagePackMapper.copy(), - ValueType.ARRAY, - new ArrayValueToTarantoolTupleResultConverter(tupleConverter) - ); + return withConvertersWithoutTargetClass(messagePackMapper.copy(), Arrays.asList( + new ValueConverterWithInputTypeWrapper<>( + ValueType.ARRAY, + new ArrayValueToTarantoolTupleResultConverter(tupleConverter) + ), + new ValueConverterWithInputTypeWrapper<>( + ValueType.NIL, + new DefaultNilValueToNullConverter() + ) + )); }possible-solution.patch
akudiyar commentedon Mar 20, 2023
Although I don't like the idea of passing a list of converters simultaneously (that gives some ambiguity about the order of these converters in the stack), I agree with this bugfix in general.