Clear the linter, and fix the three things it found

cli/files.go

@@ -207,18 +207,23 @@ func (c *archiveCmd) run(ctx context.Context, args []string) error {
 	if err != nil {
 		return err
 	}
-	defer body.Close()
+	defer func() { _ = body.Close() }()
 
-	w := io.Writer(os.Stdout)
 	if c.out != "" {
 		f, err := os.Create(c.out)
 		if err != nil {
 			return err
 		}
-		defer f.Close()
-		w = f
+		// Closed by hand rather than deferred, and the error is returned. An
+		// archive is written to a file someone means to keep, and a close that
+		// fails is the one that flushes the last of it.
+		if _, err := io.Copy(f, body); err != nil {
+			_ = f.Close()
+			return err
+		}
+		return f.Close()
 	}
-	_, err = io.Copy(w, body)
+	_, err = io.Copy(os.Stdout, body)
 	return err
 }
 

gh/client.go

@@ -179,6 +179,13 @@ func (c *Client) GetJSON(ctx context.Context, rawURL string, s Surface, v any) (
 	if err != nil {
 		return nil, err
 	}
+	// 406 and 410 are routing answers, not failures, so the fetch let them
+	// through. For a caller that wanted JSON they are the end of the road, and
+	// saying which road is more use than the decoder's complaint about the
+	// HTML it was handed.
+	if resp.Status == http.StatusNotAcceptable || resp.Status == http.StatusGone {
+		return resp, noJSONHere(rawURL)
+	}
 	if v != nil {
 		if err := json.Unmarshal(resp.Body, v); err != nil {
 			return resp, errs.New(errs.KindNetwork, "cannot decode the json from %s: %v", shortURL(rawURL), err)
@@ -403,10 +410,14 @@ func (c *Client) Poll(ctx context.Context, rawURL string, s Surface) (*Response,
 // --- URL building ---
 
 // Page builds a github.com URL from path segments, escaping each one.
+//
+// It really does escape now. It used to copy the segments across untouched
+// while the comment said otherwise, which is the kind of helper that works
+// until the first branch with a space in its name.
 func Page(parts ...string) string {
 	esc := make([]string, 0, len(parts))
 	for _, p := range parts {
-		esc = append(esc, p)
+		esc = append(esc, url.PathEscape(p))
 	}
 	return BaseURL + "/" + strings.Join(esc, "/")
 }

gh/commit.go

@@ -706,7 +706,6 @@ func (c *Client) Release(ctx context.Context, repo, tag string, opts ReleaseOpti
 		rel.setIdentity(KindRelease, repo+"@"+tag)
 	}
 	rel.addSource(res.FinalURL)
-	tag = rel.Tag
 	if !opts.Body {
 		rel.Body, rel.BodyHTML = "", ""
 	}
@@ -1114,7 +1113,7 @@ func isMailboxHeader(line string) bool {
 
 func isHex(s string) bool {
 	for _, r := range s {
-		if !(r >= '0' && r <= '9' || r >= 'a' && r <= 'f') {
+		if (r < '0' || r > '9') && (r < 'a' || r > 'f') {
 			return false
 		}
 	}

gh/contents.go

@@ -478,7 +478,7 @@ func (c *Client) Download(ctx context.Context, repo, ref, path string, w io.Writ
 	if err != nil {
 		return 0, err
 	}
-	defer body.Close()
+	defer func() { _ = body.Close() }()
 	return io.Copy(w, body)
 }
 

gh/discover.go

@@ -275,9 +275,7 @@ func (c *Client) TopicPage(ctx context.Context, slug string) (*Topic, error) {
 			t.StargazerCount = intp(n)
 		}
 	}
-	for _, rel := range relatedTopics(doc, slug) {
-		t.Related = append(t.Related, rel)
-	}
+	t.Related = append(t.Related, relatedTopics(doc, slug)...)
 	if t.DisplayName == "" && t.Description == "" {
 		return nil, structureChanged(slug)
 	}

gh/domain.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"net/http"
 	"path/filepath"
-	"time"
 
 	"github.com/tamnd/any-cli/kit"
 )
@@ -137,7 +136,3 @@ func newClientFor(_ context.Context, cfg kit.Config) (any, error) {
 	c.HTTP = &http.Client{Timeout: conf.Timeout}
 	return c, nil
 }
-
-// timeoutFor is the per-command ceiling for the walks that can run long, used
-// by the byte-plane commands that do not get a kit-managed context.
-const timeoutFor = 10 * time.Minute

gh/people.go

@@ -712,7 +712,7 @@ func firstTime(ss ...string) *time.Time {
 
 // --- the rails pager ---
 
-// nextPageToken returns the page number to ask for next, or empty when the page
+// railsNext returns the page number to ask for next, or empty when the page
 // says there is no next.
 //
 // Two templates write the same link two ways: the organization roster marks it