Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for loading allowed client public keys from a file via a new
--allow-listflag fortailcat serve.This makes access control easier to manage in real deployments, especially when the list of trusted clients is longer than a single CLI argument or needs to be maintained outside of the command line.
Changes
--allow-listto the server CLI#--allowbehaviorWhy
Previously, allowed clients had to be specified through a comma-separated list in
--allow. That works for small setups, but it becomes cumbersome and error-prone for larger or more dynamic deployments.Using a file-based allow list makes it easier to:
Example
Example file:
Testing
If you want, I can also give you: